Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/DataStores: Sort ConditionalContentTuning container by OrderIndex #29994

Merged
merged 2 commits into from
May 19, 2024

Conversation

meji46
Copy link
Member

@meji46 meji46 commented May 19, 2024

Changes proposed:

  • Sort ConditionalContentTuning container by OrderIndex. DB2Manager::GetRedirectedContentTuningId will return the ContentTuningId with the highest OrderIndex in case several valid redirectflags for the ParentContentTuningId are sent by parameter

Issues addressed:
None

Tests performed:
Builds, tested in-game
Before:

ContentTuningId: 2385
RedirectFlags: 32 -> 2537
RedirectFlags: 64 + 32 -> 2537
RedirectFlags: 256 + 64 + 32 -> 2537
RedirectFlags: 256 + 32 -> 2537

After:

ContentTuningId: 2385
RedirectFlags: 32 -> 2537
RedirectFlags: 64 + 32 -> 2533
RedirectFlags: 256 + 64 + 32 -> 2594
RedirectFlags: 256 + 32 -> 2594

Known issues and TODO list: (add/remove lines as needed)
None

@Shauren Shauren merged commit b46bba8 into TrinityCore:master May 19, 2024
4 of 6 checks passed
@meji46 meji46 deleted the content-tuning/redirect branch May 19, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants