[CORE/SPELLS] Fix immuniry checks on apply aura.

[devilcoredev]

Some AOE auras need a immunity checks before the handle of their effects. This commit will fix a bug introdouced on 08bcbc8

[Vincent-Michael]

work fine :)

[QAston]

This won't work because HandleEffect here just turns on the effect of the aura, aura will be applied anyways on unit update. Imo, you should edit effectMask variable at the begining of the Spell::DoSpellHitOnUnit function, so everything will be handled properly and with minimal effort.

[devilcoredev]

@QAston i've tested my fix and it works fine, it works for area auras like Desecration, it was part of a fix (#4229) that i've forgotten on this pull request: #4229

[QAston]

Ok, you're right, i didn't check your patch correctly @ first, there's still a problem however.Imo it's not a good idea to add immunity check in there - Aura::UpdateTargetMap is a place for such manipulations because there're immunity checks for area auras.
Also about 08bcbc8 :
08bcbc8#L2L1565
this check will only prevent aura effects being applied only on first update, because the check is run again in Aura::Update. You can avoid this problem by changing effMask in whole function, so aura will be created without effects to which target is immune, and then update problem is gone.
If you won't do that, aura will be readded to the target after immunity to a non-area-aura expires (dunno if it's intended behaviour or not)

[devilcoredev]

Mmmm, i don't have the problems that you have mentioned :|

[Star-lion]

we can has? :D

[QAston]

I've designed that part of the code (auras) so i know what i'm saying:P Anyways - it's not just a matter of bugs, putting immunity check in Unit::_ApplyAura is wrong by design, that should be handled in place where spell tatrgets are checked (Aura::UpdateTargetMap), because Unit::_ApplyAura is fully abstract and should be left that way (we don't want to have messy code, right?). I'll take care about this pull request in the middle of february, I'm too busy to apply and review now, sorry for that:(

[Star-lion]

^that. QAston you should really go in the irc ^^

[Star-lion]

its mid feb :D