Fix/ragdoll wal #18
Merged
Fix/ragdoll wal #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. 部分常量抽出到utils包内，后续考虑常量分离 2. 去除logrus日志，全面替换成zap 3. 删除无用工具函数，包括lock与panic 4. segment增加opened状态字段，结构内字段转私有，外部只能通过方法访问 5. segment写与截断均实现COW(Copy On Write)，保证写入文件的原子性
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 63.92% 69.29% +5.36%
==========================================
Files 2 2
Lines 682 710 +28
==========================================
+ Hits 436 492 +56
+ Misses 168 140 -28
Partials 78 78 ☔ View full report in Codecov by Sentry. |
RocooHash
approved these changes
Feb 18, 2024
RocooHash
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.