Skip mounting if not on actions page

Trinovantes · Apr 15, 2022 · 92a0c18 · 92a0c18
1 parent 54e2257
commit 92a0c18
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/components/UserscriptApp.vue b/src/components/UserscriptApp.vue
@@ -3,6 +3,7 @@ import { ref, defineComponent, onMounted, computed } from 'vue'
 import UserscriptAppSettings from './UserscriptAppSettings.vue'
 import { useStore } from '@/store'
 import { deleteWorkflowRuns } from '@/services/github/deleteWorkflowRuns'
+import { isOnWorkflowsPage } from '@/utils/isOnWorkflowsPage'
 
 export default defineComponent({
     components: {
@@ -39,8 +40,9 @@ export default defineComponent({
 
         return {
             title: `${DEFINE.PRODUCT_NAME} ${DEFINE.VERSION}`,
-            projectUrl: DEFINE.REPO.url,
             isOpen: ref(false),
+            isOnWorkflowsPage: isOnWorkflowsPage(window.location),
+
             numDeletionsLeft,
             stopDeleting,
             startDeleting,
@@ -50,7 +52,10 @@ export default defineComponent({
 </script>
 
 <template>
-    <div class="userscript-delete-workflow-runs">
+    <div
+        v-if="isOnWorkflowsPage"
+        class="userscript-delete-workflow-runs"
+    >
         <div
             v-if="isOpen"
             class="dialog-wrapper"

diff --git a/src/services/github/deleteWorkflowRuns.ts b/src/services/github/deleteWorkflowRuns.ts
@@ -1,12 +1,6 @@
-import { isOnWorkflowsPage } from '@/utils/isOnWorkflowsPage'
 import { waitForSelector } from '@/utils/waitForSelector'
 
 export async function deleteWorkflowRuns(numWorkflowRunsToKeep: number, onBeforeDelete?: () => Promise<void>): Promise<void> {
-    if (!isOnWorkflowsPage(window.location)) {
-        console.warn(DEFINE.NAME, 'Not on workflows page')
-        return
-    }
-
     const container = document.querySelector('#partial-actions-workflow-runs')
     if (!container) {
         throw new Error('Cannot find container')