New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Android App Bundle #262
Comments
Seems like the API was updated to include them which is nice: https://developers.google.com/android-publisher/api-ref/edits/bundles. Should be a fairly straightforward change. The only problem I see is determining the developer intent as to whether they want to publish an APK or a bundle. |
I've been trying to enable this with the intent of having parallel tasks for APKs and Bundles. Unfortunately, I'm at an impasse that I can't resolve.
These build just fine for the plugin. However, when I try to reference that plugin in a project that is compatible with https://github.com/gtcompscientist/gradle-play-publisher/tree/bundles |
Update, with my latest push, I've got it properly trying to push the bundle (wasn't setting the right
The first "but" is relatively trivial, but would cause the plugin to crash/fail Gradle sync for a project that doesn't use a version of Android Tools that includes the The second "but" is thornier, because you would end up hunting for that file, which is 😞... |
…undle task "setup" and "dependsOn". [Triple-T#262]
File a bug for each and link it here. I will escalate. |
…but currently it doesn't successfully upload for me. [Triple-T#262]
Was able to get the bundle (albeit somewhat surreptitiously) and attempt the upload. From my logging it appears to properly upload all of the data (~35.6MB), but there's a timeout happening inside the Relevant Code: |
Yeah, you'll want to go into the helper file and wrap the credential in an intercepter which boosts the timeouts. I was going to share my fork with everyone a few days ago, but I get a weird 404 everytime I try uploading. I've contacted support so we'll see how that goes. |
🤦♂️ Great tip, @SUPERCILEX, definitely helped. However, it appears there's another issue in the API with uploading secondary data: Digging into the API a little more, it looks like there may be a deeper change needed in how the plugin handles the "What's New" (See: Edit.tracks) |
…le uploading of deobfuscation files, and "What's new" until the bugs are sorted out with that data coming after a Bundle upload. [Triple-T#262]
Just a heads up that those two issues might be closed since they're problems with the Google Play Developer API and not Android Gradle itself. If they are I'll file them internally. I would also look for a place to report feedback directly to the Google Play Developer team on their website/documentation. |
Yeah, I used the question icon on the Play Console to file a support request. I'll update this issue whenever it gets resolved, but dunno if @gtcompscientist you want to file a request too anyway. |
I'll submit one when I get back to my machine, I should have realized I needed to submit those there. |
@gtcompscientist looks like they released a v3 of their client library to support the new tracks/releases structure: |
@bhurling Yep. I'll dig in today, if I have time. Definitely changes a fair amount! |
…tConfig" on Gradle tools 2.3.0, but success on 3.1.0! [#262]
…tConfig" on Gradle tools 2.3.0, but success on 3.1.0! [#262]
…ay-publisher into cb/wip/kotlin * 'cb/wip/kotlin' of https://github.com/Triple-T/gradle-play-publisher: More exhaustive Plugin version testing for Kotlin. Digging in I'd like to see if there's a way to solve this, before forcing people to update old AGP versions. Update plugin tests to be more exhaustive. They are ignored by default, because they take too long to run for everyday tests. Test suite to show the failure of the plugin usage of "android.defaultConfig" on Gradle tools 2.3.0, but success on 3.1.0! [#262] Bump the timeout to 100 seconds for http connections, and add a configuration option in case this needs to be adjusted by individual projects for bandwidth/size issues. [#144] Fix readme reference as suggested in PR
Thinking more about this, I don't think we should add a task for this, you're either uploading Bundles or APKs, so it should probably be a configuration flag. This, of course, assumes that some of the previously mentioned issues are corrected anytime soon. |
Any estimate on when this will be available from the snapshot release? Would be awesome to try out. |
@knordbo I'll see if we can get this in a snapshot build tomorrow. (The code is there, it's just waiting to be reviewed) |
@SUPERCILEX cheers! |
So it's done? Great 👍 Which version / snapshot do I need? And how do I enable it to output an App Bundle instead of an APK? |
There are a new set of tasks:
If you're using play {
// ...
defaultToAppBundles = true
} This is false by default because App Bundles require Google Play App Signing. The snapshot build instructions are available here. |
I tested the snapshot build and I could upload my app bundle without any problems! Thanks for the awesome work! |
@peterfortuin Woot! v2.0 is going to be awesome! 😁 |
When switching to |
Change |
Thx @knordbo - that's helping. But now I'm running into the next error:
Is there a readme / howto on how to migrate to 2.0.0? I've only found the CHANGELOG but there's nothing about the |
I've reported that issue before @SUPERCILEX might know when the fix for it will be in. The workaround is to create the play folder with release notes inside. |
Hmm, I cannot find a corresponding issue for the I found out, that I needed to create the file |
Yup that is the workaround. Issue #361 is indeed the problem. It appears to be marked resolved, but as you point out the issue still remains. |
Will there be a new release with this included (when)? |
Hi,
Do you plan to integrate the new "Android App Bundle" feature ?
https://android-developers.googleblog.com/2018/05/io-2018-everything-new-in-google-play.html
https://www.youtube.com/watch?v=bViNOUeFuiQ
the new command is : 'gradlew app:bundle'
https://youtu.be/bViNOUeFuiQ?t=14m10s
Thanks for all
Thomas :)
The text was updated successfully, but these errors were encountered: