Added changeUserFraction that change userFraction #110
Conversation
shiraji
force-pushed
the
104_changeUserFraction
branch
from
204e890
to
1ef2633
Compare
shiraji
changed the title
|
@bhurling Could you check this pull request? Thanks. I haven't implement a function that passes user fraction as a command line option, since that might affect the current userFraction. |
|
I think you are asking this to the wrong person. I'm not maintainer or collaborator of this plugin. |
ChristianKatzmann
force-pushed
the
master
branch
3 times, most recently
from
3a0dbeb
to
90dd846
Compare
|
@shiraji well, but the PR is directly related with the feature you added. I mean, you could merge that branch into this PR and go forward in a tested way :·) |
| @@ -47,4 +49,14 @@ class PlayPublishTask extends DefaultTask { | |||
| } | |||
| } | |||
|
|
|||
| def getTrackByName(String trackName) { | |||
There was a problem hiding this comment.
This can be written in a more Groovy-ish way:
def getTrackByName(String trackName) {
def tracksList = edits.tracks().list(variant.applicationId, editId).execute()
return tracksList.getTracks().find { it.getTrack() == trackName }
}
There was a problem hiding this comment.
Before fixing this code, I would like you guys ( @ChristianBecker @bhurling ) discuss about where this plugin goes.
As far as I remember, @bhurling didn't want to add some features that are not related with gradle build process (#108 and #110). Here is the comments.
If you guys decide merging this in, I would fix this and the conflicts as soon as possible.
|
Gonna leave this one open since we haven't decided on pursuing the issue or not internally, but the Kotlin rewrite is still going to kill it. |
|
Closing since the Kotlin rewrite has been merged and this PR is now obsolete. |
see #104
This one may conflict with #108