Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fancy logo #328

Merged
merged 9 commits into from Jun 15, 2018
Merged

Add fancy logo #328

merged 9 commits into from Jun 15, 2018

Conversation

masudr4n4
Copy link
Contributor

@masudr4n4 masudr4n4 commented Jun 13, 2018

Fixes #309

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Copy link
Collaborator

@maaudrana Awesome, thanks! Do you think you could upload another SVG with less padding?

@masudr4n4
Copy link
Contributor Author

@SUPERCILEX hey you can download svg file from here.can you please add this logo to readme file?

@SUPERCILEX
Copy link
Collaborator

@maaudrana Still looks like the SVG there has a ton of whitespace around it. I was hoping for it to be a little bit more zoomed in. If that's not possible, no problemo though it would be highly appreciated.

@masudr4n4
Copy link
Contributor Author

I am confusing actually what you want.please clear me well i will try my best.

@SUPERCILEX SUPERCILEX changed the title logo Add fancy logo Jun 14, 2018
@SUPERCILEX
Copy link
Collaborator

Yeah, do you see how much whitespace the logo has here?
image

I was hoping for something more zoomed in like this:
image

But in SVG form. Does that make sense?

@knordbo
Copy link
Contributor

knordbo commented Jun 15, 2018

What he means is that SVGs shouldn't contain outer padding. You should have no padding as the SVG in the zip folder I've attached here. You never want to be in a situation where you need to update an asset in order to modify padding/alignment etc.

When you include it using
<img alt="Logo" src="assets/logo.svg" width="50%" />
thats when you add width height and any desired padding. Something like:
<img alt="Logo" src="assets/logo.svg" width="50%" height="50%" style="padding:50px" />

logo.svg.zip

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Copy link
Collaborator

@knordbo thanks for that! I don't have Illustrator so I was kinda stuck there. (Though I see you used sketch... either way, don't know how to use those tools so thanks.)

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@bhurling
Copy link
Contributor

Any reason we're not using md language?

@SUPERCILEX
Copy link
Collaborator

SUPERCILEX commented Jun 15, 2018

@bhurling Because we want to look fancy! 😁⬇️
image

@bhurling
Copy link
Contributor

Haha. Well, then...

@bhurling bhurling merged commit 992ed4c into Triple-T:master Jun 15, 2018
@bhurling
Copy link
Contributor

Thanks a lot @maaudrana. That logo looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants