Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_resetYasgui url param does not work anymore to delete browser storage #139

Open
JJ-Author opened this issue Jan 14, 2020 · 4 comments
Open

Comments

@JJ-Author
Copy link

JJ-Author commented Jan 14, 2020

while http://yasgui.org/?a=b&_resetYasgui deletes your local storage this seems not to work anymore for the new yasgui 4 version

@LaurensRietveld
Copy link
Contributor

Interesting to see that this was used. Could you elaborate a bit more on your use case? Perhaps there is a better solution that is visible to more users than the ones 'in the know'

@JJ-Author
Copy link
Author

Sometimes it happened that the local storage got messed up because of one strange tab which got somehow broken. Then this was useful to send the user having trouble this link. Moreover when I improved yasgui settings, this was not reflected without deleting local storage. As a computer scientist myself I can also use the dev tools to delete local storage or disable it permanently during development. But maybe for others an option to reset in the GUI instead would be helpful?

So if it was intended that it does not work anymore you can of course close the issue.

@LaurensRietveld
Copy link
Contributor

Thanks for the explanation.
Would the following suit your use cases?

  • a button in the yasgui settings to 'reset yasgui'
  • better error handling for irrecoverable errors, such as an error dialog with the option the reset yasgui

Ps. Next time you have such an error, could you submit your local storage value in an issue? I recall having similar issues in the previous version, and want to avoid such fragile behavior in this new release

@JJ-Author
Copy link
Author

Thanks for the explanation.
Would the following suit your use cases?

  • a button in the yasgui settings to 'reset yasgui'

Yes this sounds great. and I would be happy about it.

  • better error handling for irrecoverable errors, such as an error dialog with the option the reset

I don't know what you mean by irrecoverable errors, but yes this also sounds good. But it would not be a 'must-have' for us at the moment.

Ps. Next time you have such an error, could you submit your local storage value in an issue? I recall having similar issues in the previous version, and want to avoid such fragile behavior in this new release

Alright I will. So far I did not have trouble like this in the v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants