Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard '_t' fixed-width types instead of rolling our own, where available #31

Merged
merged 2 commits into from
Oct 28, 2018

Conversation

brc0x1
Copy link
Member

@brc0x1 brc0x1 commented Oct 28, 2018

This PR switches us to use the standard fixed-width integer types (int8_t, uint32_t, etc.) instead of rolling our own (which we were doing because stdint.h / cstdint didn't exist back in 1998). This is mostly an aesthetic change, but it's one less thing to go awry at configure time.

Couple of other minor small tweaks:

  • cArchive::Write() takes a const string reference instead of a string by value
  • Catch some exceptions by const reference instead of nonconst reference in keyfile.cpp
  • Change return type of cErrorQueue::GetNumErrors()

@brc0x1 brc0x1 merged commit a95dd9e into dev/2438 Oct 28, 2018
@brc0x1 brc0x1 deleted the feature/standard-types branch February 3, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant