Better error messages for missing config fields #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| func unmarshallConfig(data []byte) (*Config, error) { |
There was a problem hiding this comment.
The word "unmarshal" has 1 "L" not 2. You've got a double-l in a couple places in this PR.
|
LGTM other than the minor little spelling mistake. |
justenwalker
force-pushed
the
missing-fields
branch
from
c4941b1
to
61e9096
Compare
|
LGTM. Thanks @justenwalker! |
tgross
added a commit
that referenced
this pull request
Dec 14, 2015
Better error messages for missing config fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes all required fields for backends and services have error messages
For #43