Add support for etcd #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func (c Etcd) deregisterService(service *ServiceConfig) error { | ||
| _, err := c.API.Delete(context.Background(), c.getNodeKey(service), &client.DeleteOptions{Dir: true, Recursive: true}) |
There was a problem hiding this comment.
can you break this long line?
|
@justenwalker we've got a merge conflict here now that #59 has been merged. |
justenwalker
force-pushed
the
etcd_backend
branch
from
ece01d6
to
639bf3f
Compare
|
@tgross rebased |
| - 4001:4001 | ||
| restart: always | ||
|
|
||
| nginx: |
There was a problem hiding this comment.
The ports/expose spec for this should be:
ports:
- 80
without an expose stanza.
- Make error checks idiomatic - Make intent clear with comments
justenwalker
force-pushed
the
etcd_backend
branch
from
dde459f
to
f3cd1d1
Compare
|
@tgross rebased |
|
Awesome. Let's ship it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds etcd as an alternate discovery backend
Changes
github.com/coreos/etcd/clientmake run-consulto run the consul examplemake run-etcdto run the etcd examplemake clean-consulto stop and clean up the consul examplemake clean-etcdto stop and clean up the etcd exampleFor #11
🎊 Happy New Year 🎊