Make golang dependencies a non-phony target #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
gh64_no_phony_deps
branch
from
6eca025
to
84bde74
Compare
|
Odd... what I have here seems to work for the first run but then is treating |
Ah, which you already ran into in https://github.com/joyent/containerbuddy/pull/58/files#diff-cd5dbf3629c558b0104ba8f0937d6816R48. I'll rebase on that and double-check. |
Mount the .godeps directory on the local machine nested within the /go/src directory so that we can run our build without manipulating the GOPATH but still take advantage of caching the cloned dependencies on disk.
tgross
force-pushed
the
gh64_no_phony_deps
branch
from
84bde74
to
1e1bd4e
Compare
|
Ok, rebased on |
|
LGTM - it's really nice to increase the iteration speed like this. |
tgross
added a commit
that referenced
this pull request
Jan 5, 2016
Make golang dependencies a non-phony target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #64
Mount the
.godeps/directory (on the local machine) to a spot nested within the/go/srcdirectory in the build container so that we can run our build without manipulating theGOPATHbut still take advantage of caching the cloned dependencies on disk.cc @justenwalker