Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-8513 Update coreutils in illumos-extra #105

Merged
merged 1 commit into from Jan 12, 2024
Merged

OS-8513 Update coreutils in illumos-extra #105

merged 1 commit into from Jan 12, 2024

Conversation

danmcd
Copy link
Contributor

@danmcd danmcd commented Jan 12, 2024

Changes were simple enough once moved over to 64-bit builds. Needs testing.

@danmcd danmcd requested a review from a team January 12, 2024 01:40
Copy link
Member

@bahamat bahamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on switching those things to 64-bit.

@danmcd
Copy link
Contributor Author

danmcd commented Jan 12, 2024

Good call on switching those things to 64-bit.

Easiest Y2038-solution for these. (Also modern 32-bit compilation required Linux glibc extended-time_t akin to LARGEFILE support. Didn't wanna bother.)

Do need to test some before I push. Seems appropriate for next SmartOS. THanks!

@danmcd
Copy link
Contributor Author

danmcd commented Jan 12, 2024

I've added some small test notes to the ticket. Please ACK or NAK here depending on if you need more tests or not.

@danmcd danmcd merged commit 7f471ad into master Jan 12, 2024
3 checks passed
@danmcd danmcd deleted the OS-8513 branch January 12, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants