Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP pinger hangs #102

Closed
davepacheco opened this issue Mar 14, 2017 · 1 comment
Closed

HTTP pinger hangs #102

davepacheco opened this issue Mar 14, 2017 · 1 comment

Comments

@davepacheco
Copy link
Contributor

With #78 fixed, I went to try using the pinger again with cueball 2.2.0, but I found that HTTP requests were all queueing up. The pinger requests appear to have hung.

According to @arekinath, this is because of an argument mix-up that causes the agent to use the claim handle is if it were the socket. Nothing in Node's HTTP or socket implementations seem to notice this, but our callback is never invoked.

@arekinath
Copy link
Contributor

The node http logic simply checks socket.writable, and if it's non-truthy (which it is, it's undefined), then it registers a handler on .on('writable', ...) -- which works fine, because the ClaimHandle is an EventEmitter. It'll just never emit that. So we're stuck. Forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants