-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyPassphrase option to signer #115
Add keyPassphrase option to signer #115
Conversation
Can you run 'make check' -- it looks like there's a couple of minor formatting errors -- can you fix this and update the PR? |
There you go, fixed those. However it looks like my
|
It looks like the two issues are:
The json utility is:
(i.e. |
Thanks for the help; since it is used by a dev tool I'd add it to dev dependencies and also add the Anyway, the |
Hello everyone, When I download this package, I tried in 2 different projects, with "npm i http-signature@latest" the code from this PR is not included, the file "signer.js" is only 450 lines instead of 483. My package.json indicates version 1.3.4 Am I doing something wrong? Thanks in Advance, |
@NigelNec this package simply didn't get a release since this PR was merged (yet). check the commit history |
Understood, I'll download the zip file for now. |
I'll get a release cut and updated on npm. It'll probably be tomorrow when that happens. |
Fix #81
Allow requests to be signed with a private key that is protected with a passphrase.