-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Signature header support. #83
Conversation
Hello, any plan to merge this PR? Thanks, |
@jclulow any idea? ☝️ |
I'm currently building a drone.io plugin where the drone server sends the signature header over, so support for this would be desirable. Would love to see feedback on this and potential merging. |
@mattzuba I have met this problem in the same scene, so I created the pr. Right now we can overwrite @arekinath can you have a look this pull request and merge it? thx~ |
Hello, Do we have a chance to see this PR merged in the near future? |
Done. Hope this help addressing PSD2 issues. |
- fixes node 0.10 usage which was broken by PR #83 and released in v1.3.0 - updates jsstyle and javascriptlint to latest versions on the joyent github org - various style nits
As specification said, It also support header named
Signature
and there has no scheme in field value.Both parser and signer should be update to support
signature
header. I have different logic inparser.js
andsigner.js
.About sign generator part, we only need to add support for
Signature
header if developer set in options, because the format is different withAuthorization
header (just omit scheme part).While we'll use this module to parser http request from different service, we should have max compatibility in parser part. So I will try to get authorizationHeaderName which developer set, then try to get
authorization
header, at last I'll try to getsignature
header.close #77 when pr merged.