Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM package shouldn't include any code that does require('JSV') #11

Closed
arekinath opened this issue Oct 15, 2015 · 2 comments
Closed

NPM package shouldn't include any code that does require('JSV') #11

arekinath opened this issue Oct 15, 2015 · 2 comments

Comments

@arekinath
Copy link
Contributor

If we include code that uses require() on a library we don't have as any kind of declared dependency, some tools that depend on "static analysis" of requirements like browserify will break.
arekinath added a commit to arekinath/node-jsprim that referenced this issue Oct 15, 2015
@arekinath
TritonDataCenter#11 NPM package shouldn't include any code that requi…
dadc341 
…res JSV
arekinath added a commit to arekinath/node-jsprim that referenced this issue Oct 15, 2015
@arekinath
TritonDataCenter#11 NPM package shouldn't include any code that requi…
56cc633 
…res JSV
arekinath added a commit to arekinath/node-jsprim that referenced this issue Oct 15, 2015
@arekinath
TritonDataCenter#11 NPM package shouldn't include any code that requi…
0f2ad65 
…res JSV
@davepacheco
Copy link
Contributor

Commit 0f2ad65 LGTM.

@davepacheco
Copy link
Contributor

Published with v1.2.2.

@nmajor nmajor mentioned this issue Apr 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arekinath @davepacheco