Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extsprintf dependency #22

Closed
danielbprice opened this issue Aug 1, 2017 · 3 comments
Closed

Update extsprintf dependency #22

danielbprice opened this issue Aug 1, 2017 · 3 comments

Comments

@danielbprice
Copy link

My build system is presently stuck behind a firewall, the misconfiguration of which is making it hard to get to github. We have a caching NPM proxy, which works well, and all of the modules we use during the build are presently cached. However, when node-jsprim pulls in a relatively old version of extsprintf (1.0.2), the git submodules initialization fails for git://github.com/... URIs. Those git submodules were removed from extsprintf in commit 76e9d14be8d6a jsPrintf dicey use of arguments. So updating the dependency would help us out in this (admittedly fringe) case.

I'm filing this issue and will followup with a PR to resolve it along with #21.

Happy to take guidance on other solutions, but this seemed to me to make sense.

@davepacheco
Copy link
Contributor

Sure!

This repo uses a different contribution process now, but that was never updated in the README or a contributing file. I'll put together a change for this issue, #21, and to update the contribution guidelines.

@davepacheco
Copy link
Contributor

Proposed change: https://cr.joyent.us/#/c/2317/1

This is make prepush clean.

joyent-automation pushed a commit that referenced this issue Aug 2, 2017
#22 Update extsprintf dependency
#23 update contribution guidelines
Reviewed by: Richard Kiene <richard.kiene@joyent.com>
Approved by: Richard Kiene <richard.kiene@joyent.com>
@davepacheco
Copy link
Contributor

Published in v1.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants