-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extsprintf dependency #22
Comments
Sure! This repo uses a different contribution process now, but that was never updated in the README or a contributing file. I'll put together a change for this issue, #21, and to update the contribution guidelines. |
Proposed change: https://cr.joyent.us/#/c/2317/1 This is |
Published in v1.4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My build system is presently stuck behind a firewall, the misconfiguration of which is making it hard to get to github. We have a caching NPM proxy, which works well, and all of the modules we use during the build are presently cached. However, when
node-jsprim
pulls in a relatively old version ofextsprintf
(1.0.2), thegit submodules
initialization fails for git://github.com/... URIs. Those git submodules were removed from extsprintf in commit 76e9d14be8d6a jsPrintf dicey use of arguments. So updating the dependency would help us out in this (admittedly fringe) case.I'm filing this issue and will followup with a PR to resolve it along with #21.
Happy to take guidance on other solutions, but this seemed to me to make sense.
The text was updated successfully, but these errors were encountered: