Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x509 certificates with string containing "_" can't be parsed by Go TLS #22

Closed
arekinath opened this issue Jan 13, 2017 · 0 comments
Closed

x509 certificates with string containing "_" can't be parsed by Go TLS #22

arekinath opened this issue Jan 13, 2017 · 0 comments

Comments

@arekinath
Copy link
Contributor

arekinath commented Jan 13, 2017 •
edited
Loading

Leads to output like:

Could not load X509 key pair: asn1: syntax error: PrintableString contains invalid character.

Turns out we're always writing an ASN.1 PrintableString tag, even when the string contains an _ (which is not a "printable" character in ASN.1 definitions). We should output this as an IA5String or UTF8String.
@trentm trentm mentioned this issue Jan 14, 2017
Closed
joyent-automation pushed a commit that referenced this issue Jan 14, 2017
@arekinath
#22 x509 certificates with string containing "_" can't be parsed by G…
3ae5356 
…o TLS

Reviewed by: Cody Mello <cody.mello@joyent.com>
Approved by: Cody Mello <cody.mello@joyent.com>
joyent-automation pushed a commit to TritonDataCenter/node-triton that referenced this issue Feb 2, 2017
@trentm
#166 see fix for TritonDataCenter/node-sshpk#22 before release
1503088 
Reviewed by: Alex Wilson <alex.wilson@joyent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arekinath