Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests fail with openssl 1.1.0e because of extra spaces in DN output #29

Closed
pravi opened this issue May 11, 2017 · 1 comment
Closed

Comments

@pravi
Copy link

pravi commented May 11, 2017

OpenSSL 1.1.0e 16 Feb 2017 possible new format introduced in OpenSSL

tape test/openssl-cmd.js 
TAP version 13
# openssl version
# make temp dir
ok 1 null
# pkcs8 rsa public key parses
ok 2 should be equal
ok 3 should be equal
ok 4 should be equal
ok 5 should be truthy
# pkcs8 rsa private key parses
ok 6 should be equal
ok 7 should be equal
ok 8 should be equal
ok 9 should be truthy
# pkcs8 rsa public key output
ok 10 output produced
ok 11 should be equal
ok 12 should be equal
# pkcs8 rsa private key output
ok 13 output produced
ok 14 should be equal
ok 15 should be equal
# sign with sshpk, openssl dgst verify
ok 16 should be equal
ok 17 should be equal
# sign with openssl, verify with sshpk
ok 18 should be equal
ok 19 should be truthy
ok 20 should be truthy
# make a self-signed cert, parse with openssh
ok 21 should be equal
not ok 22 should be equal
  ---
    operator: equal
    expected: 'CN=rsa, C=US'
    actual:   'CN = rsa, C = US'
    at: ChildProcess.<anonymous> (/home/pravi/forge/debian/git/pkg-javascript/node-sshpk/test/openssl-cmd.js:225:6)
  ...
not ok 23 should be equal
  ---
    operator: equal
    expected: 'CN=rsa, C=US'
    actual:   'CN = rsa, C = US'
    at: ChildProcess.<anonymous> (/home/pravi/forge/debian/git/pkg-javascript/node-sshpk/test/openssl-cmd.js:228:6)
  ...
ok 24 should be equal
ok 25 should be equal
# make a self-signed cert, verify with openssh
ok 26 should be equal
ok 27 should be equal
# make a self-signed cert with utf8 chars
ok 28 should be equal
ok 29 should be equal
# verify a self-signed cert with utf8 chars
ok 30 should be equal
ok 31 should be equal
ok 32 should be equal
ok 33 should not be equal
ok 34 should be equal
ok 35 should be equal
ok 36 should not be equal
ok 37 should be truthy
# make a self-signed cert with non-printable chars
ok 38 should be equal
ok 39 should be equal
ok 40 should be equal
ok 41 should not be equal
ok 42 should be equal
ok 43 should be equal
ok 44 should not be equal
ok 45 should be truthy
# make a self-signed cert with generated key
# make temp dir
ok 46 null
# pkcs8 dsa public key parses
ok 47 should be equal
ok 48 should be equal
ok 49 should be equal
ok 50 should be truthy
# pkcs8 dsa private key parses
ok 51 should be equal
ok 52 should be equal
ok 53 should be equal
ok 54 should be truthy
# pkcs8 dsa public key output
ok 55 output produced
ok 56 should be equal
ok 57 should be equal
# pkcs8 dsa private key output
ok 58 output produced
ok 59 should be equal
ok 60 should be equal
# sign with sshpk, openssl dgst verify
ok 61 should be equal
ok 62 should be equal
# sign with openssl, verify with sshpk
ok 63 should be equal
ok 64 should be truthy
ok 65 should be truthy
# make a self-signed cert, parse with openssh
ok 66 should be equal
not ok 67 should be equal
  ---
    operator: equal
    expected: 'CN=dsa, C=US'
    actual:   'CN = dsa, C = US'
    at: ChildProcess.<anonymous> (/home/pravi/forge/debian/git/pkg-javascript/node-sshpk/test/openssl-cmd.js:225:6)
  ...
not ok 68 should be equal
  ---
    operator: equal
    expected: 'CN=dsa, C=US'
    actual:   'CN = dsa, C = US'
    at: ChildProcess.<anonymous> (/home/pravi/forge/debian/git/pkg-javascript/node-sshpk/test/openssl-cmd.js:228:6)
  ...
ok 69 should be equal
ok 70 should be equal
# make a self-signed cert, verify with openssh
ok 71 should be equal
ok 72 should be equal
# make a self-signed cert with utf8 chars
ok 73 should be equal
ok 74 should be equal
# verify a self-signed cert with utf8 chars
ok 75 should be equal
ok 76 should be equal
ok 77 should be equal
ok 78 should not be equal
ok 79 should be equal
ok 80 should be equal
ok 81 should not be equal
ok 82 should be truthy
# make a self-signed cert with non-printable chars
ok 83 should be equal
ok 84 should be equal
ok 85 should be equal
ok 86 should not be equal
ok 87 should be equal
ok 88 should be equal
ok 89 should not be equal
ok 90 should be truthy
# make a self-signed cert with generated key
# make temp dir
ok 91 null
# pkcs8 ecdsa public key parses
ok 92 should be equal
ok 93 should be equal
ok 94 should be equal
ok 95 should be truthy
# pkcs8 ecdsa private key parses
ok 96 should be equal
ok 97 should be equal
ok 98 should be equal
ok 99 should be truthy
# pkcs8 ecdsa public key output
ok 100 output produced
ok 101 should be equal
ok 102 should be equal
# pkcs8 ecdsa private key output
ok 103 output produced
ok 104 should be equal
ok 105 should be equal
# sign with sshpk, openssl dgst verify
ok 106 should be equal
ok 107 should be equal
# sign with openssl, verify with sshpk
ok 108 should be equal
ok 109 should be truthy
ok 110 should be truthy
# make a self-signed cert, parse with openssh
ok 111 should be equal
not ok 112 should be equal
  ---
    operator: equal
    expected: 'CN=ecdsa, C=US'
    actual:   'CN = ecdsa, C = US'
    at: ChildProcess.<anonymous> (/home/pravi/forge/debian/git/pkg-javascript/node-sshpk/test/openssl-cmd.js:225:6)
  ...
not ok 113 should be equal
  ---
    operator: equal
    expected: 'CN=ecdsa, C=US'
    actual:   'CN = ecdsa, C = US'
    at: ChildProcess.<anonymous> (/home/pravi/forge/debian/git/pkg-javascript/node-sshpk/test/openssl-cmd.js:228:6)
  ...
ok 114 should be equal
ok 115 should be equal
# make a self-signed cert, verify with openssh
ok 116 should be equal
ok 117 should be equal
# make a self-signed cert with utf8 chars
ok 118 should be equal
ok 119 should be equal
# verify a self-signed cert with utf8 chars
ok 120 should be equal
ok 121 should be equal
ok 122 should be equal
ok 123 should not be equal
ok 124 should be equal
ok 125 should be equal
ok 126 should not be equal
ok 127 should be truthy
# make a self-signed cert with non-printable chars
ok 128 should be equal
ok 129 should be equal
ok 130 should be equal
ok 131 should not be equal
ok 132 should be equal
ok 133 should be equal
ok 134 should not be equal
ok 135 should be truthy
# make a self-signed cert with generated key
ok 136 should be equal
ok 137 should be equal
# teardown

1..137
# tests 137
# pass  131
# fail  6
@arekinath arekinath changed the title 6 tests from test/openssl-cmd.js fail because of extra spaces in CN tests fail with openssl 1.1.0e because of extra spaces in DN output May 25, 2017
@arekinath
Copy link
Contributor

Thanks for reporting this!

Patch review: https://cr.joyent.us/#/c/2005/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants