Terminate pg_xlogdump once an iteration #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pg_xlogdump(1)'s `-f` flag will "tail" a WAL file until a new WAL entry is appended to the WAL file. If PostgreSQL has shutdown or disappeared, pg_xlogdump(1) needs to be aware of this state change and be terminated by the prefaulter. Fixes: #40
Required in order to allow pg_xlogdump(1) to complete before having its context shutdown in the event that PostgreSQL is starting up and the pg_prefaulter can't connect to the DB.
I think I like this approach more.
gwydirsam
approved these changes
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PostgreSQL is terminated,
pg_prefaulter's spawned instances ofpg_xlogdumpwill still have an open file descriptor becausepg_xlogdumpis being invoked with the-fflag. Introduce a new context that is used and tied to PostgreSQL connections. Unfortunately this means we now sleep for a small duration before actually terminatingpg_xlogdump(1)or closing FDs, however the default sleep duration is1s.Fixes: #40