Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOOLS-2557 Update eng for new Rust Makefiles. #8

Merged
merged 2 commits into from Jan 27, 2023
Merged

TOOLS-2557 Update eng for new Rust Makefiles. #8

merged 2 commits into from Jan 27, 2023

Conversation

travispaul
Copy link
Member

@travispaul travispaul commented Jan 23, 2023 •
edited

Updated deps/eng and Makefile for new Rust tooling.

@travispaul travispaul mentioned this pull request Jan 23, 2023
Merged
@travispaul travispaul marked this pull request as ready for review January 27, 2023 16:40
@travispaul travispaul requested a review from a team January 27, 2023 16:40
danmcd
danmcd approved these changes Jan 27, 2023
View reviewed changes
Copy link

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible. Make sure you get a 2nd on this if you can.

bahamat
bahamat approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@bahamat bahamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@travispaul travispaul merged commit 26afc9d into master Jan 27, 2023
@travispaul travispaul deleted the TOOLS-2557 branch January 27, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmcd danmcd danmcd approved these changes

@bahamat bahamat bahamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@travispaul @danmcd @bahamat