TRITON-239 VMAPI should use reusable moray buckets initialization/data migrations module

[joyent-automation]

TRITON-239 VMAPI should use reusable moray buckets initialization/data migrations module

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/3605/.
The raw archive of this CR is here.
See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@misterdjules commented at 2018-03-13T05:06:04

Uploaded patch set 2: Patch Set 1 was rebased.

@trentm commented at 2018-04-19T22:54:36

Patch Set 3: Code-Review-1

(1 comment)

Patch Set 3 code comments

lib/apis/moray.js#1795 @trentm

Before switching VMAPI to triton-merci-buckets we need a change here in that module:

diff --git a/lib/data-migrations.js b/lib/data-migrations.js
index 2f3e0d1..5592230 100644
--- a/lib/data-migrations.js
+++ b/lib/data-migrations.js
@@ -487,6 +487,10 @@ function _putBatch(bucketName, records, options, callback) {
         return {
             bucket: bucketName,
             operation: 'put',
+            // XXX This needs to change to just use and require `record.key`.
+            //     See TRITON-329. As well, I'm not sure we can assume the
+            //     key is the same as `value.uuid` in all cases. E.g. that
+            //     isn't true for some sdc-docker buckets.
             key: record.value.uuid,
             value: record.value,
             etag: record._etag

See TRITON-329 for details.