Possible bug with use of bunyan 0.19.0

[nshalman]

Today I did a build of SmartOS including commit ee8dc20

When I used it, I got some error messages when I did a vmadm create that did not prevent creation, but are not a good sign:

bunyan: ERROR: This should never happen. This is a bug in <https://github.com/trentm/node-bunyan> or in this application. Exception from "vms" Logger serializer: TypeError: Object.keys called on non-object
    at Function.keys (native)
    at Object.vmSerializer [as vms] (/usr/fw/lib/util/log.js:90:17)
    at Logger._applySerializers (/usr/node/0.8/node_modules/bunyan.js:644:46)
    at Array.forEach (native)
    at Logger._applySerializers (/usr/node/0.8/node_modules/bunyan.js:640:33)
    at new Logger (/usr/node/0.8/node_modules/bunyan.js:459:10)
    at Function.createLogger (/usr/node/0.8/node_modules/bunyan.js:1219:10)
    at createLogger (/usr/fw/lib/util/log.js:153:16)
    at Object.logEntry [as entry] (/usr/fw/lib/util/log.js:276:3)
    at logEntry (/usr/fw/lib/fw.js:72:13)
bunyan: ERROR: This should never happen. This is a bug in <https://github.com/trentm/node-bunyan> or in this application. Exception from "vms" Logger serializer: TypeError: Object.keys called on non-object
    at Function.keys (native)
    at Object.vmSerializer [as vms] (/usr/fw/lib/util/log.js:90:17)
    at Logger._applySerializers (/usr/node/0.8/node_modules/bunyan.js:644:46)
    at Array.forEach (native)
    at Logger._applySerializers (/usr/node/0.8/node_modules/bunyan.js:640:33)
    at mkRecord (/usr/node/0.8/node_modules/bunyan.js:756:15)
    at Logger.trace (/usr/node/0.8/node_modules/bunyan.js:784:13)
    at /usr/fw/lib/fw.js:324:9
    at Array.forEach (native)
    at createVMlookup (/usr/fw/lib/fw.js:313:7)
bunyan: ERROR: This should never happen. This is a bug in <https://github.com/trentm/node-bunyan> or in this application. Exception from "vms" Logger serializer: TypeError: Object.keys called on non-object
    at Function.keys (native)
    at Object.vmSerializer [as vms] (/usr/fw/lib/util/log.js:90:17)
    at Logger._applySerializers (/usr/node/0.8/node_modules/bunyan.js:644:46)
    at Array.forEach (native)
    at Logger._applySerializers (/usr/node/0.8/node_modules/bunyan.js:640:33)
    at mkRecord (/usr/node/0.8/node_modules/bunyan.js:756:15)
    at Logger.debug (/usr/node/0.8/node_modules/bunyan.js:784:13)
    at filterRulesByRemoteVMs (/usr/fw/lib/fw.js:847:7)
    at remoteVMrules (/usr/fw/lib/fw.js:1668:9)
    at Object.func (/usr/fw/lib/pipeline.js:50:7)
bunyan: ERROR: This should never happen. This is a bug in <https://github.com/trentm/node-bunyan> or in this application. Exception from "vms" Logger serializer: TypeError: Object.keys called on non-object
    at Function.keys (native)
    at Object.vmSerializer [as vms] (/usr/fw/lib/util/log.js:90:17)
    at Logger._applySerializers (/usr/node/0.8/node_modules/bunyan.js:644:46)
    at Array.forEach (native)
    at Logger._applySerializers (/usr/node/0.8/node_modules/bunyan.js:640:33)
    at mkRecord (/usr/node/0.8/node_modules/bunyan.js:756:15)
    at Logger.debug (/usr/node/0.8/node_modules/bunyan.js:784:13)
    at filterVMsByRules (/usr/fw/lib/fw.js:789:7)
    at matchingVMs (/usr/fw/lib/fw.js:1673:9)
    at Object.func (/usr/fw/lib/pipeline.js:50:7)
bunyan: ERROR: This should never happen. This is a bug in <https://github.com/trentm/node-bunyan> or in this application. Exception from "vms" Logger serializer: TypeError: Object.keys called on non-object
    at Function.keys (native)
    at Object.vmSerializer [as vms] (/usr/fw/lib/util/log.js:90:17)
    at Logger._applySerializers (/usr/node/0.8/node_modules/bunyan.js:644:46)
    at Array.forEach (native)
    at Logger._applySerializers (/usr/node/0.8/node_modules/bunyan.js:640:33)
    at mkRecord (/usr/node/0.8/node_modules/bunyan.js:756:15)
    at Logger.debug (/usr/node/0.8/node_modules/bunyan.js:784:13)
    at filterRulesByVMs (/usr/fw/lib/fw.js:936:7)
    at vmRules (/usr/fw/lib/fw.js:1686:9)
    at Object.func (/usr/fw/lib/pipeline.js:50:7)
bunyan: ERROR: This should never happen. This is a bug in <https://github.com/trentm/node-bunyan> or in this application. Exception from "vms" Logger serializer: TypeError: Object.keys called on non-object
    at Function.keys (native)
    at Object.vmSerializer [as vms] (/usr/fw/lib/util/log.js:90:17)
    at Logger._applySerializers (/usr/node/0.8/node_modules/bunyan.js:644:46)
    at Array.forEach (native)
    at Logger._applySerializers (/usr/node/0.8/node_modules/bunyan.js:640:33)
    at mkRecord (/usr/node/0.8/node_modules/bunyan.js:756:15)
    at Logger.trace (/usr/node/0.8/node_modules/bunyan.js:784:13)
    at restartFirewalls (/usr/fw/lib/fw.js:1434:7)
    at restart (/usr/fw/lib/fw.js:1576:9)
    at Object.func (/usr/fw/lib/pipeline.js:50:7)

[trentm]

Thanks. We are digging into this now.

[trentm]

Fixed in Bunyan 0.20.0 (trentm/node-bunyan) which we'll get into this repo soon.

[trentm]

Fixed in 6ee62a2