-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bunyan dependency change and logging fix #12
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue with logging
I believe this resolves #11 |
The actual exception from bunyan is:
|
The logging bug appears to be caused by TritonDataCenter/smartos-live#184; see trentm/node-bunyan@1a8be0c. The correct fix is to move forward to bunyan 0.21 rather than to fix on 0.18.0. |
ghost
pushed a commit
that referenced
this pull request
May 21, 2013
#12 Bunyan dependency change and logging fix
Thanks for the report. 0.1.4 should work for you now. |
ghost
closed this
May 21, 2013
Good call, thanks for the fix. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting errors with the serializers and Bunyan 0.18.3 in my environment; fixed the dependency on 0.18.0 which works fine.
Also got "Error: getsockname EINVAL" when trying to access conn.address()... Anyways, figured it's safe to assume it'll be the host/port we were trying for.