Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-8382 Update README.md #1043

Merged
merged 3 commits into from May 17, 2022
Merged

OS-8382 Update README.md #1043

merged 3 commits into from May 17, 2022

Conversation

jsadowyj
Copy link
Contributor

@jsadowyj jsadowyj commented May 6, 2022

Updates README.md to show git rather than scmgit.

@jsadowyj jsadowyj self-assigned this May 6, 2022
danmcd
danmcd reviewed May 6, 2022
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Slack, you're going to have to be a bit more surgical about this change. The rewhacking of '*' to '-' is going to mess up some set of MD rendering tools we may reconstitute here at MNX.

@jsadowyj jsadowyj requested a review from danmcd May 17, 2022 06:13
danmcd
danmcd reviewed May 17, 2022
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the lighter-weight fix.

@danmcd danmcd merged commit bea2d73 into master May 17, 2022
@danmcd danmcd deleted the OS-8382 branch May 17, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmcd danmcd danmcd left review comments

@bahamat bahamat bahamat approved these changes

Assignees

@jsadowyj jsadowyj

Labels
integration-approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsadowyj @danmcd @bahamat