OS-8501 imgadm will not import active images if they have any inactive origin images #1083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an image which has children images is disabled, none of those children images can be imported. I bumped into this on a fresh server that didn’t have
b70d5484-5168-4ecb-8127-0a0c59c1d906
(a Ubuntu 20.04 image) on it yet:The problem is that
b70d5484-5168-4ecb-8127-0a0c59c1d906
is an active image, but it has an origin (parent) image9aa48095-da9d-41ca-a094-31d1fb476b98
which was disabled (it’s Ubuntu 18.04, and now EOL). It makes sense to disable the origin image as a result, but we still want the child image to continue to be deployable.After talking to some operators, they want the ability to disable an outdated origin image without affecting the availability of all derived images. This change makes that possible.
With this change:
Disabled images still cannot be imported:
However any child images that depend on it can still be imported: