Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOOLS-2574 Purge dependency on us-east.manta.joyent.com name #17

Merged
merged 2 commits into from Apr 24, 2024

Conversation

bahamat
Copy link
Member

@bahamat bahamat commented Apr 23, 2024

No description provided.

@bahamat bahamat requested a review from a team April 23, 2024 19:17
Copy link

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit that's not a blocker, but I want it brainworming a little.

describes the current plan and status.

## Setup

Grafana requires either a Triton or Manta Prometheus instance to exist, and will
also function with both simultaneously. Ensure that
[Prometheus](https://github.com/joyent/triton-prometheus) is set up in your
[Prometheus](https://github.com/TritonDataCenter/triton-prometheus) is set up in your
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not now, but given our current triton-prometheus situation, perhaps this needs fixing later?

@bahamat bahamat merged commit e6c6b1e into master Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants