-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to override an existing check #8
Comments
@S-Koell The guideline check G-1050 was already part of the Trivadis guidelines v2. Back then it was named G-05. Hence the check methods were also named checkGuideline5. There are two implemented one for string literals and one for number literals. I've created an example where I've re-implemented the guideline completely. See here. In your case you could also simplify the implementation to:
It's a bit tricky to navigate the parse tree. I typically implement the code with the help of the debugger, which I call from a test. |
Sorry for the late response but: WOW huge thanks for actually coding everything there! But shouldn't it be:
And I think this issue here is the right place to ask the development topics from the issue #10 :
|
No, Regarding the other questions, I suggest to open dedicated issues. Thank you. |
I agree.
No call to super. That's why I asked if it's correct. |
The current implementation is not wrong. It just reimplements the validation completely. I wanted to make clear that reusing the existing implementation is also possible. |
Understood. I thought that this could be the case but I couldn't be sure without knowing the default implementation, hence the question. Thanks for clarification and a HUGE thanks for all the great and fast support you give! |
This questions was asked by @S-Koell in another forum. Here's the relevant part:
The text was updated successfully, but these errors were encountered: