Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the roundend & lobbymusic playlists a config thing instead of hardcoded #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Altoids1
Copy link
Collaborator

@Altoids1 Altoids1 commented Jan 28, 2020

Changelog

🆑 Altoids
tweak: Roundend & lobbymusic sounds are now defined in-config instead of being hardcoded.
/:cl:

@Altoids1 Altoids1 changed the title Makes the roundend playlist a config thing instead of hardcoded. Makes the roundend & lobbymusic playlists a config thing instead of hardcoded. Jan 28, 2020
@Altoids1 Altoids1 changed the title Makes the roundend & lobbymusic playlists a config thing instead of hardcoded. Makes the roundend & lobbymusic playlists a config thing instead of hardcoded Jan 28, 2020
@Altoids1 Altoids1 added the Config The host machine's config must be altered for this to work. label Jan 29, 2020
@Altoids1
Copy link
Collaborator Author

Travis is complaining because the current playlist for one of these is blank. Will fix.

@Amelia0010
Copy link
Contributor

why tho

@monster860
Copy link
Contributor

The list of lobby music was originally a config thing then we moved to having it be in the code so that PRs could be opened on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config The host machine's config must be altered for this to work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants