Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greek theta incorrectly maps to 8 #353

Closed
colinbate opened this issue Oct 2, 2022 · 2 comments · Fixed by #354
Closed

Greek theta incorrectly maps to 8 #353

colinbate opened this issue Oct 2, 2022 · 2 comments · Fixed by #354

Comments

@colinbate
Copy link

I'm not sure if this was a conscious decision based on appearance, and I am not Greek and not an expert, but I do have some Greek content, and I believe that the Greek letter theta (Θ) would be best transliterated to Th. With the lowercase θ being th.
@Trott
Copy link
Owner

Trott commented Oct 2, 2022

Yes, that certainly seems like a suboptimal choice.

Trott added a commit that referenced this issue Oct 2, 2022
@Trott
fix: slugify θ as th
c0d0d62 
Fixes: #353
@Trott Trott mentioned this issue Oct 2, 2022
Merged
@Trott Trott closed this as completed in #354 Oct 2, 2022
Trott added a commit that referenced this issue Oct 2, 2022
@Trott
fix: slugify θ as th (#354)
19e8ca1 
Fixes: #353
@Trott
Copy link
Owner

Trott commented Oct 2, 2022

Fixed in slug@8.2.2. Thanks for the bug report.

rymercad added a commit to rymercad/slug that referenced this issue Apr 23, 2024
@rymercad
fix: slugify θ as th (#354)
38763c2 
Fixes: Trott/slug#353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: slugify θ as th Trott/slug
2 participants
@Trott @colinbate