Add Option to use Bumpmines as Innocent

[Saueee]

Add Option to use Bumpmines as Innocent

[Mrkl21full]

Well... If you want to do such a thing, you should add usages per role and then register it depending on the usages (0 means disabled, higher then 0 means enabled for specific role).

EDIT:
After some "thinking" this should be okay for know but idk if you should check the team when client buys item depending on the configuration you just provided.

[Saueee]

I couldn't find out why some Items got 2 Vars like this:
HAMMER_D_ITEM_SHORT
HAMMER_T_ITEM_SHORT
But I don't think this is neccessary for this change. (?)

Also I forgot to set default for bumpmine.type to 2 for Traitor only

[Mrkl21full]

Because when you buys something it has a "short name" and "forward event" will pass that thing you just bought to others plugins and that plugins can check if this is from t shop, or d shop and do some actions if necessary.

Your change don't have it, you should add it.

[Saueee]

Added T/D Versions. Please review :)

[Mrkl21full]

Good work, but it can be optimized.

I can't edit it for you (i don't have the perms :D) but I did it small changes for you (just copy&paste it) PR-466

EDIT:
We don't need too much code if it will do the same

[Mrkl21full]

We only need to let @Bara decide whether "bumpmine_type" should be 1 or 2.

[Bara]

@Saueee I did't played with bumpmines yet, does make it any damages to (other) players?

[Saueee]

@Bara They don't do direct damage but fall damage if players walk over it and can't land anywhere.
They open up some maps because you can jump on towers and houses with them.
Should be traitor only in default in my opinion but option for all would be nice.