Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occasionally, RankMove doesn't animate #7

Closed
Trouv opened this issue May 21, 2022 · 4 comments · Fixed by #58
Closed

Occasionally, RankMove doesn't animate #7

Trouv opened this issue May 21, 2022 · 4 comments · Fixed by #58
Labels
fix Something isn't working
Milestone

Comments

@Trouv
Copy link
Owner

Trouv commented May 21, 2022

Not sure what's happening here, hopefully it's just a scheduling issue.

It's super noticeable when it happens. Willo doesn't move transform-wise for the first part of his movement, then eases to the destination in the second part of the movement.

It's just visual, it seems.

@Trouv Trouv added the fix Something isn't working label May 21, 2022
@Trouv
Copy link
Owner Author

Trouv commented Jul 11, 2022

This has likely been fixed by 4ca3ad7
However, I'll keep this open until we don't observe it for a while. It's hard to reproduce this bug on purpose.

@Trouv
Copy link
Owner Author

Trouv commented Jul 11, 2022

Well, this didn't fix it, or at the very least, it wasn't the only problem causing it. I wonder if some of it is just purely performance hiccups.

@Trouv
Copy link
Owner Author

Trouv commented Jul 11, 2022

Possibly fixed, again, in 5b35f5f

@Trouv Trouv added this to the mvp milestone Aug 19, 2022
@Trouv
Copy link
Owner Author

Trouv commented Aug 23, 2022

It's easier to reproduce on a lower framerate. If you move during the same update that the animation transition between pushing and idling is performed, this happens. Probably an issue with easing scheduling, which I thought I fixed, but I guess I didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant