Fix android.view.WindowManager$BadTokenException crashes #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st activity is not finished yet.
|
I will test this out in the next week or two. |
|
The default promptInterval was changed from 10 to 1 btw. |
|
Changed it back to its original value. Thanks for your time. |
|
Its in production. No more crashes :) |
cvanderschuere
added a commit
to indie-technologies/cordova-plugin-remote-injection
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected issue #31
The fix consists of checking whether the host activity, where the dialog is about to be shown, is still running and only proceed if it is, hence avoiding the crash from happening.