Fix SimpleAdderVM test cases after #17 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output was:
1) Contract: SimpleAdderVM should merklize state:
AssertionError: expected '0xce14df43546288f0a098d4057077c167f41c3cbcd4011965d53430d2e99d3dfb' to equal '0x235bae0e9307973e69b4c4da79fa631652c75cc382c9d097ff28dfcd702e8e25'
Output was:
2) Contract: SimpleAdderVM should run a step:
Error: Invalid number of arguments to Solidity function
Output was:
3) Contract: SimpleAdderVM should run steps:
AssertionError: expected [ Array(2) ] to deeply equal [ Array(2) ]
+ expected - actual
[
[
- "0x4000000000000000000000000000000000000000000000000000000000000000"
- "0xa000000000000000000000000000000000000000000000000000000000000000"
+ "0x0000000000000000000000000000000000000000000000000000000000000004"
+ "0x0000000000000000000000000000000000000000000000000000000000000004"
+ "0x0000000000000000000000000000000000000000000000000000000000000006"
"0x0000000000000000000000000000000000000000000000000000000000000005"
]
- "0xe72f7cc82a531b841eeb3b3a0ae1be6dad22bdec19b87a38f535df65c0ed4b06"
+ "0x00b6b0f456d4b05f44bd2f7ad745e2350d8dfd0bd68cdda97c011e988ca58998"
]
|
Ah good catch! Thanks for the PR! |
|
happy to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, in #17 the state was change from 4 registers to 3 registers, and the omitted register was added as a
runStep()parameter. This updates the test cases to reflect this.In addition, test case program "instructions" were fixed to be of type
bytes32instead ofbyte, as single-byte values were being assigned to the MSB, yielding registers encoded in big-endian format. (See description of third commit.)After these changes, running
truffle testproduces: