Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put wiki in read-only if git-operations failed #75

Closed
TrueBrain opened this issue Nov 12, 2020 · 1 comment
Closed

Put wiki in read-only if git-operations failed #75

TrueBrain opened this issue Nov 12, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@TrueBrain
Copy link
Owner

Currently, if git commit fails for what-ever reason, this goes unnoticed by the users. Their change will only not appears on GitHub, and on next reload, disappear.

Fix this by capturing such events, and put the wiki in read-only till an operator fixed it.
@TrueBrain TrueBrain added the bug Something isn't working label Nov 12, 2020
@TrueBrain
Copy link
Owner Author

Changed my mind: we are simply going to terminate the process if such unexpected exception happens.

In normal production workflows, this should cause the start of a new process, cleaning everything back up (but the commit will be lost).
In development workflows, it makes it more clear what happened immediately.

TrueBrain added a commit that referenced this issue Nov 13, 2020
@TrueBrain
Fix #75: escalate exceptions from tasks to main thread
8acbc46 
This means that an unexpected exception will terminate the
application completely, instead of hiding away a bit.
TrueBrain added a commit that referenced this issue Nov 13, 2020
@TrueBrain
Fix #75: escalate exceptions from tasks to main thread
fa03e3d 
This means that an unexpected exception will terminate the
application completely, instead of hiding away a bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TrueBrain