Skip to content

Feature/3 rename contracts #5

Merged

Conversation

KirillovDenis
Copy link

close #3

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Contract names in config.yml;
  2. Archive target in Makefile;
  3. README appearances.

Not sure if these ones should be changed in that PR.

@fyrchik
Copy link

fyrchik commented Jan 10, 2023

What about neofsid?

@KirillovDenis
Copy link
Author

What about neofsid?

As I understand NeoFSID contract is a contract deployed in NeoFS sidechain, but this PR is about mainchain

@fyrchik
Copy link

fyrchik commented Jan 10, 2023

Yeah, I mean can we do it here too?

@realloc
Copy link

realloc commented Jan 10, 2023

If we are ok with renaming everything at once, let's rename everything.

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
alexvanin
alexvanin previously approved these changes Jan 11, 2023
README.md Outdated
| v0.14.x | [v2.11.0](https://github.com/nspcc-dev/neofs-api/releases/tag/v2.11.0) |
| v0.15.x | [v2.11.0](https://github.com/nspcc-dev/neofs-api/releases/tag/v2.11.0), [v2.12.0](https://github.com/nspcc-dev/neofs-api/releases/tag/v2.12.0) |
| v0.15.x | [v2.11.0](https://github.com/nspcc-dev/neofs-api/releases/tag/v2.11.0), [v2.12.0](https://github.com/nspcc-dev/neofs-api/releases/tag/v2.12.0) |
| v0.16.x | [v2.14.0](https://github.com/nspcc-dev/neofs-api/releases/tag/v2.14.0) |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this table is relevant for frostfs.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Let us just drop it.

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
@fyrchik fyrchik merged commit 4077921 into TrueCloudLab:master Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename mainnet contracts
5 participants