Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection timeout #38

Merged
merged 11 commits into from
Apr 11, 2023
Merged

Conversation

ThomWright
Copy link
Member

Adds a connect_timeout() option to LoadBalancedChannelBuilder.

Relevant to #37.

Note: hyperium/tonic#1215 will need merging first for this to work.

@ThomWright ThomWright requested a review from a team as a code owner December 28, 2022 11:25
conradludgate
conradludgate previously approved these changes Dec 28, 2022
@ThomWright ThomWright mentioned this pull request Jan 2, 2023
conradludgate
conradludgate previously approved these changes Apr 2, 2023
Copy link
Contributor

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want some safe defaults here? If I specify just a timeout but no connect_timeout, should the connect_timeout be assumed to be the same as timeout?

tests/tests/all/lookup.rs Outdated Show resolved Hide resolved
Co-authored-by: Conrad Ludgate <oon@conradludgate.com>
@ThomWright
Copy link
Member Author

Do we want some safe defaults here? If I specify just a timeout but no connect_timeout, should the connect_timeout be assumed to be the same as timeout?

I like this idea. Done.

@ThomWright
Copy link
Member Author

I apparently don't have write access to merge 🥺

@conradludgate conradludgate merged commit 8026765 into TrueLayer:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants