Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update packages dependant on http v1 #133

Closed
wants to merge 5 commits into from
Closed

update packages dependant on http v1 #133

wants to merge 5 commits into from

Conversation

campeis
Copy link

@campeis campeis commented Mar 21, 2024

Updated reqwest, hyper and wire mock to work with http v1

@campeis campeis requested a review from a team as a code owner March 21, 2024 07:42
@campeis campeis changed the title update packages dependet on http v1 update packages dependant on http v1 Mar 21, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Luca Palmieri <20745048+LukeMathWalker@users.noreply.github.com>
@charliermarsh
Copy link

@LukeMathWalker - Is there anything I can do to help support this upgrade?

@LukeMathWalker
Copy link
Collaborator

LukeMathWalker commented Mar 23, 2024

I no longer have commit access to this repository (nor publish access to the package on crates.io).
We need one of the current maintainers to pick it up (@eopb?).

@LukeMathWalker
Copy link
Collaborator

Btw, you should also update the README @campeis

serde = "1.0.106"
task-local-extensions = "0.1.4"
thiserror = "1.0.21"

[dev-dependencies]
reqwest = { version = "0.12.0", default-features = false, features = ["json", "multipart", "native-tls"] }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to enable "native-tls" for tests to make the test in README file to be able to connect over https

Comment on lines +21 to +23
reqwest-middleware = "0.2.5"
reqwest-retry = "0.4.0"
reqwest-tracing = { version = "0.4.8", features = ["opentelemetry_0_18"] }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these versions should be updated for the next release

@eopb
Copy link
Member

eopb commented Apr 3, 2024

Thank you for this PR @campeis. I'm sorry it took so long to review.

These changes were also made in #135 so I'm going to close this PR. Thanks again for making these changes.

@eopb eopb closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants