New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some new methods to extensions #4

Merged

conradludgate merged 2 commits into main from some-changes

Aug 30, 2022

Contributor

conradludgate commented Aug 30, 2022

Cleans up the code a little

HashMap::new() is a cleap already so wrapping it in an Option is unnecessary.
with_extensions doesn't need an extra RefCell, although that didn't cost too much anyway 🤷

Adds 2 new methods to Extensions:

Extensions::with(self, T) -> Self - a builder style insert for quickly initialising the extensions.
Extensions::append(&mut self, &mut Self) - analogous to https://doc.rust-lang.org/std/vec/struct.Vec.html#method.append


          add some new methods to extensions

354eede

conradludgate requested a review from a team as a code owner

August 30, 2022 15:34


          docs

44ca4f8

tl-rodrigo-gryzinski approved these changes

View reviewed changes

conradludgate merged commit 8e1c6df into main

conradludgate deleted the some-changes branch

August 30, 2022 18:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment