Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

[feat][auth] include all options to generate the authURL #29

Merged
merged 4 commits into from
Jul 31, 2019

Conversation

smontiu
Copy link
Contributor

@smontiu smontiu commented Jul 25, 2019

Include all possible option to pass to getAuthUrl method at AuthAPIClient class

Now getAuthUrl receives a config object, (Interface IConfig created) including required properties and new ones:

enableCredentialsSharing,
enableCredentialsSharingDe,
enableOauth,
enableOpenBanking,
disableProviders,
providerId

Mayor version recommendation: broke old method compatibility, multiple params to just one object including all config properties.

Copy link
Contributor

@riccardoio riccardoio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR :)

I will test and merge if everything is ok.

@riccardoio riccardoio merged commit aaf8e1c into TrueLayer:master Jul 31, 2019
@smontiu
Copy link
Contributor Author

smontiu commented Jul 31, 2019

@riccardoio thanks, remember to also create new tag (v2.0.0) in order to be able to update our dependency in our package.json. Like I mention on the PR description, I will bump a major version, because this change brakes backward compatibility with getAuthUrl previous method.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants