Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(EWT-361): Workflows review #256

Merged
merged 23 commits into from
Dec 21, 2023
Merged

refactor(EWT-361): Workflows review #256

merged 23 commits into from
Dec 21, 2023

Conversation

dili91
Copy link
Contributor

@dili91 dili91 commented Dec 21, 2023 •
edited

This PR reviews our GH workflow significantly, to:

  • Make sure that contributions from external collaborators can be merged, once approved by TL actors
  • Increase the readability of what is a shared step and what is an actual workflow: all that's prefixed with workflow- is triggered via a github event (push on main, push on internal branch that is not main, PR on fork event)
  • Deprecate the old set-output command
  • Update the java setup action to v4

@swarmia Swarmia
Copy link

swarmia bot commented Dec 21, 2023

✅  Linked to Task EWT-361 · [Java lib] Review GH Workflow to support runs on PRs raised by external contributors

@dili91 dili91 marked this pull request as ready for review December 21, 2023 11:18
@dili91 dili91 requested review from a team as code owners December 21, 2023 11:18
@dili91 dili91 changed the title [EWT-361] Workflows review refactor(EWT-361): Workflows review Dec 21, 2023
@dili91 dili91 merged commit 1fcca0b into main Dec 21, 2023
18 checks passed
@dili91 dili91 deleted the ci-wf-review branch December 21, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tl-luca-baggi tl-luca-baggi tl-luca-baggi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dili91 @tl-luca-baggi