Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix access errors #28

Merged
merged 1 commit into from
Feb 20, 2023
Merged

fix: fix access errors #28

merged 1 commit into from
Feb 20, 2023

Conversation

yuxqiu
Copy link
Collaborator

@yuxqiu yuxqiu commented Feb 20, 2023 •
edited
Loading

Fix problems caused by accessing self.__env in Classifier and self.__title, self.__url and self.__description in HistoryAwareKnowledgeComponent

@yuxqiu
fix: fix access errors
d90b2da 
fix problems caused by accessing `self.__env` in Classifier and `self.__title/url/description` in
HistoryAwareKnowledgeComponent
deniselezi
deniselezi approved these changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@deniselezi deniselezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran my code and it worked, so LGTM

@yuxqiu yuxqiu merged commit d7c8966 into main Feb 20, 2023
@KD-7 KD-7 deleted the fix-access branch February 21, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniselezi deniselezi deniselezi approved these changes

@KD-7 KD-7 KD-7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuxqiu @deniselezi @KD-7