Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: try using pip install . #38

Merged
merged 9 commits into from
Mar 1, 2023
Merged

ci: try using pip install . #38

merged 9 commits into from
Mar 1, 2023

Conversation

yuxqiu
Copy link
Collaborator

@yuxqiu yuxqiu commented Feb 28, 2023

No description provided.

@TrueLearnAI TrueLearnAI deleted a comment from codecov-commenter Feb 28, 2023
@TrueLearnAI TrueLearnAI deleted a comment from codecov-commenter Feb 28, 2023
@yuxqiu yuxqiu changed the title ci: try using pip install .[tests] ci: try using pip install . Feb 28, 2023
@TrueLearnAI TrueLearnAI deleted a comment from codecov-commenter Feb 28, 2023
@yuxqiu yuxqiu marked this pull request as ready for review February 28, 2023 16:58
@yuxqiu yuxqiu requested a review from KD-7 February 28, 2023 16:59
@KD-7
Copy link
Contributor

KD-7 commented Feb 28, 2023

I dont think there is any need to have the quotes around .[tests] .[linters] you can just write it like that.

@yuxqiu
Copy link
Collaborator Author

yuxqiu commented Mar 1, 2023

I dont think there is any need to have the quotes around .[tests] .[linters] you can just write it like that.

This is to ensure that pip will install truelearn correctly when using zsh. See zsh: no matches found: requests[security].

@yuxqiu yuxqiu merged commit f46e813 into main Mar 1, 2023
@yuxqiu yuxqiu deleted the fix-ci-cache branch March 1, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KD-7 KD-7 KD-7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuxqiu @KD-7