various changes to support arm64 Apple Silicon based devices #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* typed-st [1.4.3], when compiled with newer clang versions (e.g. Apple Clang 13.0.1) and with --std=c99, throws an implicit declaration, which has been fixed in typed-st [1.5.2].
Stacktrace: ast3/Python/ast.c:4514:9: error: implicit declaration of function '_PyUnicode_DecodeUnicodeEscape' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
v = _PyUnicode_DecodeUnicodeEscape(s, len, NULL, &first_invalid_escape);
^
Signed-off-by: FraSharp <s23265@iisve.it>
* they were restoring typed-st to [1.4.3]. Signed-off-by: FraSharp <s23265@iisve.it>
* it thrown a KeyError which lead the whole UI not to render.
Stacktrace:
GNU nano 6.1 .local/share/arigram/error.log
ERROR [2022-02-16 21:43:03,216] controllers.py:922 - draw | Error happened in draw loop
Traceback (most recent call last):
File /Users/francescoduca/.local/src/arigram/arigram/controllers.py, line 920, in draw
fun()
File /Users/francescoduca/.local/src/arigram/arigram/controllers.py, line 913, in _resize
self._render()
File /Users/francescoduca/.local/src/arigram/arigram/controllers.py, line 940, in _render
self._render_chats()
File /Users/francescoduca/.local/src/arigram/arigram/controllers.py, line 957, in _render_chats
self.view.chats.draw(selected_chat, chats, self.model.chats.title)
File /Users/francescoduca/.local/src/arigram/arigram/views.py, line 234, in draw
last_msg_sender, last_msg = self._get_last_msg_data(chat)
File /Users/francescoduca/.local/src/arigram/arigram/views.py, line 267, in _get_last_msg_data
user, last_msg = get_last_msg(chat, self.model.users)
File /Users/francescoduca/.local/src/arigram/arigram/views.py, line 631, in get_last_msg
last_msg[sender].get(user_id),
KeyError: 'sender'
Signed-off-by: FraSharp <s23265@iisve.it>
Signed-off-by: FraSharp <s23265@iisve.it>
Signed-off-by: FraSharp <s23265@iisve.it>
… based devices Signed-off-by: FraSharp <s23265@iisve.it>
Signed-off-by: FraSharp <s23265@iisve.it>
Signed-off-by: FraSharp <s23265@iisve.it>
This reverts commit 15220a3.
|
Thank you <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.