CoinTicker should be Realm object.

[OlegGordiichuk]

Also we should have relationship between CoinTicker and TokenObject.

TokenObject is an ERC20 object that contains information about specific token and also current balance of the user.
CoinTicker coinmarket ticker that contains price information for the specified token. This need to be combined into TokenObject so you can easily get pricing and later sort TokenObject by total value in the tokens list.

Keep in mind, there is different currencies available.

[gitcoinbot]

This issue now has a funding of 0.05 ETH (27.92 USD @ $558.46/ETH) attached to it.

• If you would like to work on this issue you can claim it here.
• If you've completed this issue and want to claim the bounty you can do so here
• Questions? Get help on the Gitcoin Slack
• $3616.3 more Funded OSS Work Available at: https://gitcoin.co/explorer

[maektwain]

Please provide little bit description and directions.

[vikmeup]

@maektwain updated the issue, please take a look.

[DarthMike]

I understand you want to integrate CoinTicker into the Realm datastore as a relationship to the TokenObject ?

If so, should the ticker be called CoinTickerObject?

I think I will attempt this task and come with a PR during weekend.

[vikmeup]

@DarthMike thanks for doing this!

I think CoinTicker is great! I think before we had one model, we called them CoinTicker and CoinTickerObject for the realm model.

Currently, we store tickers object into NSUserDefaults, kinda sucks. But also make sure to use currency parameter to distinguish.
Also, each network has separate realm file, so you don't need to worry about that.

Do you have telegram? can you message me at vikmeup?

[vikmeup]

Yes, so currently the way it's done:
We have TokenObject then we ask viewModel for getTicker(for: TokenObject), but instead we could have some mapping

struct TokenObject {
    var price: CoinTicker
}

unless you know better alternatives? always up for it

[DarthMike]

Something has come up, won't be able to work on this for a while. Just letting you know so if somebody else wants to, they can pick it up.

[johnnynanjiang]

@vikmeup I’m looking at this issue if nobody else is.

[vikmeup]

@johnnynanjiang nice! thank you

[vs77bb]

@johnnynanjiang Feel free to pick this up on Gitcoin here by clicking 'Start Work'!

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work has been started.

1. @johnnynanjiang

has committed to working on this project to be completed 10 months from now.

, please see the below comments / questions regarding approach for this ticket from the bounty hunter(s):

[johnnynanjiang]

Thanks @vs77bb just done it

[johnnynanjiang]

Hi @vikmeup and @OlegGordiichuk, just wanted to clarify some points and get your insights.

I've made some changes so far so that CoinTicker now gets saved and retrieved from Realm (via CoinTickerObject, with a tickerskey for distinguishing currency and network. CoinTickerObject will eventually replace CoinTicker)

Now I'm looking at combining TokenObject and CoinTicker

TokenObject {
    var price: CoinTicker
}

Some options as follows:

1. Combine TokenObject and CoinTicker from service side.
   Currently, we get TokenObject and CoinTicker from two separate endpoints .getTokens and .prices (there is another RPC endpoint tokenBalance), probably we could combine them in .getTokens so that when we call .getTokens we will have TokenObject and CoinTicker details returned in the response.

2. Combine TokenObject and CoinTicker from mobile side
   We get TokenObject from .getTokens, and get CoinTicker from .prices, then combine CoinTicker into TokenObject.

3. Leave TokenObject and CoinTicker separate in Realm, as they are from separate endpoints anyway.

Which way do you prefer or if I miss or misunderstand anything here?

Thanks and regards

[vikmeup]

@johnnynanjiang I would go with option #3, I think balance and pricing should be two separate entities in general.
option #2 might work as well, but we need to make sure they could work async as well. Once I get balance it should be presented to the user and pricing comes later and update it.

I'm also open to suggestions if you have ideas on how to simplify it.

@OlegGordiichuk did you have anything in mind on this?

[johnnynanjiang]

@vikmeup yeah it makes sense, will raise a PR soon, thanks.

[vikmeup]

@johnnynanjiang another reason why we need this change to sort tokens by total value. balance * token price. Can you make sure that's possible?

[johnnynanjiang]

@vikmeup ok, I guess the idea is that there would be a new field called 'balance' in TokenObject, whenever TokenObject list or CoinTickerObject list get updated in Realm, 'balance' will get updated to 'token amount (from TokenObject) * token price (from CoinTickerObject)' in TokenObject.

How does it sound?

[vikmeup]

I think that make sense to me to have balance field on TokenObject.

I think this logic should be simplified, we could have pricing storage as it is and just update balance when pricing changes.

That’s not what original issue states tho, but that’s ok! We just need good solution.

Can you telegram me: vikmeup?

[johnnynanjiang]

@vikmeup sure, I have implemented the logic in TokensDataStore as it is where we store/update TokenObject, CoinTickerObject, and Balance. Testing at the moment, as well as implementing Realm migration as new field 'balance' has been added.

[johnnynanjiang]

@gitcoinbot yes, submitted a PR and there is some work to be done.

[gitcoinbot]

@johnnynanjiang. 👋 thanks for the atMention, but you need to install @gitcoinbot on this repo for me to be able to respond. More details in the documentation.

✌️
@gitcoinbot

[gitcoinbot]

Work for 0.05 ETH (30.31 USD @ $606.25/ETH) has been submitted by:

1. @johnnynanjiang

Submitters, please leave a comment to let the funder (and the other parties involved) that you've submitted you work. If you don't leave a comment, the funder may expire your submission at their discretion.

• Learn more on the gitcoin issue page
• Questions? Get help on the Gitcoin Slack
• $6594.15 more Funded OSS Work Available at: https://gitcoin.co/explorer

[vs77bb]

@vikmeup Mind going to the Gitcoin Issue and accepting work, assuming this one is ready for pay out? Hope you both are doing well!

[vs77bb]

@vikmeup Bump to see if @johnnynanjiang should be paid for this PR which looks to be merged. Hope you are doing well!

[vikmeup]

@vs77bb I’m pretty sure I already pressed to pay, not sure why it didn’t happen yet.

[johnnynanjiang]

It seems that the work has not been accepted yet. https://gitcoin.co/funding/details?url=https://github.com/TrustWallet/trust-wallet-ios/issues/493

…

On Tue, May 15, 2018 at 8:54 AM, Viktor Radchenko ***@***.***> wrote: @vs77bb <https://github.com/vs77bb> I’m pretty sure I already pressed to pay, not sure why it didn’t happen yet. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#493 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALXc5zYx71gdyLYUzC8KJA0rQ-6FJU2vks5tygsngaJpZM4SuenL> .

[owocki]

@vikmeup do you have a tx id for the acceptance transaction? were not seeing it here at gitcoin

[vikmeup]

@owocki when I press "Accept", it gives me this in the console:

Syntax error, unrecognized expression: select[name=bountyFulfillment [Rollbar not enabled]

I'm doing from Trust, do you what this could be?

[owocki]

@vikmeup thanks for the heads up! i just put in a fix for this ( gitcoinco/web@e9ca613 ) and deployed it!

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

The funding of 0.05 ETH (34.94 USD @ $698.88/ETH) attached to this issue has been approved & issued to @johnnynanjiang.

• Learn more at on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $8,610.51 more funded OSS Work available on the Gitcoin Issue Explorer