Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly incorrect indentation of for loop #80

Closed
poojagupta1007 opened this issue May 7, 2019 · 2 comments
Closed

Possibly incorrect indentation of for loop #80

poojagupta1007 opened this issue May 7, 2019 · 2 comments

Comments

@poojagupta1007
Copy link

The for loop in line 125 should be outside the else part.
Otherwise for loop runs for the initializations done in else part but it should work with both, if and else initializations.

https://github.com/IBM/AIF360/blob/0cf736f0310075a244dc63a045dbc7636dda2f2c/aif360/algorithms/postprocessing/reject_option_classification.py#L116-L132
@hoffmansc
Copy link
Collaborator

Good catch! Looks like you're right, it's a typo. Thanks for pointing it out!

hoffmansc added a commit that referenced this issue May 7, 2019
@hoffmansc
Fix loop indentation typo
7f9df18 
See #80
@hoffmansc hoffmansc mentioned this issue May 7, 2019
Merged
@poojagupta1007
Copy link
Author

Thank You!!

Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this issue Jun 7, 2023
@hoffmansc
Fix loop indentation typo
4bbedc6 
See Trusted-AI#80
Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this issue Jun 7, 2023
@hoffmansc @Illia-Kryvoviaz
Fix loop indentation typo
c21a1b7 
See Trusted-AI#80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hoffmansc @poojagupta1007