Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction docstring #114

Merged
merged 2 commits into from Nov 15, 2019
Merged

Correction docstring #114

merged 2 commits into from Nov 15, 2019

Conversation

autoih
Copy link
Contributor

@autoih autoih commented Oct 3, 2019

close #105

@hoffmansc
Copy link
Collaborator

The way I understood it, true labels in this context meant ground-truth.

so ...false_positives should read: weighted sum of predicted scores where true labels are 'unfavorable', since scores are always for the favorable label

and then ...false_negatives, e.g., should be weighted sum of 1 - predicted scores where true labels are 'favorable',

and finally, ...true_negatives should be weighted sum of 1 - predicted scores where true labels are 'unfavorable',

@nrkarthikeyan do you agree? Should we rephrase it as weighted sum of predicted 'scores' of instances with favorable ground-truth labels or something?

@autoih
Copy link
Contributor Author

autoih commented Oct 3, 2019

Thanks @hoffmansc. I've updated it.

@hoffmansc hoffmansc merged commit cc99fb9 into Trusted-AI:master Nov 15, 2019
Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docstrings incorrect for generalized FN, FP & TN
2 participants