scikit-learn-compatible API #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dataset loading is more similar to sklearn.datasets * label binarization is now done outside standardize_dataset * metrics use 'groups' and 'priv_group' to signify priv/unpriv split
removed Reweighing.sample_weight_ attribute
also added score function (compute weighted cost)
added additional tests to check this
* fixed German 'age' from being dropped * renamed two_year_recid labels to 'Survived' and 'Recidivated' to match ProPublica article * reordered COMPAS categories to 'Male' < 'Female' * added 'foreign_worker' protected attribute for German
hoffmansc
force-pushed
the
sklearn-compat
branch
from
5ded679
to
8fdd6dc
Compare
|
Thanks @hoffmansc. Maybe you can schedule 30 min review with @Tomcli myself ? |
|
Sure. Sent an invite. |
|
cc @adrinjalali Adrian this is a PR originating from the original request Would be great to get your feedback and review on this, as well as how can we target this toward SKLearn community? |
|
@hoffmansc @nrkarthikeyan best to get this merged if the issues are non blockers, and then we can come back with refinements. |
* added one-hot encoding example and random_states to demo notebook * added 'prefit' option to PostProcessingMeta * multiple fixes to docstring wordings * added additional links/disclaimers in docstrings * renamed CalibratedEqualizedOdds args to X and y
nrkarthikeyan
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #58
Old API:
New Sphinx docs layout
New API:
sklearn.datasets.fetch_openmlfor datasets. #53statistical_parity_difference,disparate_impact_ratio,equal_opportunity_difference,average_odds_difference,average_odds_error,between_group_generalized_entropy_error)generalized_entropy_indexand its variants,consistency_score)specificity_score,base_rate,selection_rate,generalized_fpr,generalized_fnr)Reweighing,AdversarialDebiasing,CalibratedEqualizedOdds)