Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove turtle module import #415

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Remove turtle module import #415

merged 2 commits into from
Nov 4, 2022

Conversation

gkumbhat
Copy link
Contributor

@gkumbhat gkumbhat commented Oct 7, 2022

Changes

  • Remove turtle module import, since it doesn't seem to be getting used and breaks aif360

Signed-off-by: Gaurav Kumbhat kumbhat.gaurav@gmail.com

@gkumbhat
Remove turtle module import
f6dcd9b 
Signed-off-by: Gaurav Kumbhat <kumbhat.gaurav@gmail.com>
@gkumbhat
Merge pull request #1 from gkumbhat/remove_unused_package
0749b0a 
Remove turtle module import
@gkumbhat gkumbhat mentioned this pull request Oct 7, 2022
Closed
@hoffmansc hoffmansc linked an issue Nov 4, 2022 that may be closed by this pull request
Import statement for ClassificationMetric fails in Cent OS. #374
Closed
@hoffmansc hoffmansc merged commit fef1bc9 into Trusted-AI:master Nov 4, 2022
@lanterno
Copy link

lanterno commented Mar 5, 2023

Thank you!
indeed, this import was breaking the library for us. causing some weird import to tkinter which was not available on our ML python kernels.

lanterno pushed a commit to lanterno/AIF360 that referenced this pull request Mar 9, 2023
@gkumbhat @lanterno
Remove turtle module import (Trusted-AI#415)
17e5eb6
@lanterno lanterno mentioned this pull request Mar 10, 2023
Open
lanterno pushed a commit to lanterno/AIF360 that referenced this pull request Mar 14, 2023
@gkumbhat @lanterno
Remove turtle module import (Trusted-AI#415)
3062027
@katkamrachana
Copy link

katkamrachana commented Mar 20, 2023 •
edited

@hoffmansc when can we expect an updated release with this fix?

@katkamrachana
Copy link

@hoffmansc following up on releasing new version with the fix. TIA!

Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this pull request Jun 6, 2023
@gkumbhat @Illia-Kryvoviaz
Remove turtle module import (Trusted-AI#415)
3c219f1 
Signed-off-by: Illia-Kryvoviaz <illiakryvoviaz@gmail.com>
Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this pull request Jun 7, 2023
@gkumbhat @Illia-Kryvoviaz
Remove turtle module import (Trusted-AI#415)
0b1e0ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffmansc hoffmansc hoffmansc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import statement for ClassificationMetric fails in Cent OS.
4 participants
@gkumbhat @lanterno @katkamrachana @hoffmansc